From 92ac6525edba3c5b7330b9d0ccfe82057c2a78a3 Mon Sep 17 00:00:00 2001 From: Julia Friesel <julia.friesel@gmail.com> Date: Mon, 13 Aug 2018 16:51:25 +0200 Subject: [PATCH] Solve bug where small gaps where showing in temp line --- components/chart/day-column.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/components/chart/day-column.js b/components/chart/day-column.js index 8f187361..e1f5b91f 100644 --- a/components/chart/day-column.js +++ b/components/chart/day-column.js @@ -119,8 +119,9 @@ export default class DayColumn extends Component { const heightDiff = -leftY - -rightY const angle = Math.atan2(heightDiff, colWidth / 2) const lineStyle = excludeLine ? styles.curveExcluded : styles.curve - // hypotenuse - const h = (colWidth / 2) / Math.cos(angle) + // hypotenuse, we add 3px for good measure, because otherwise the lines + // don't quite touch at the day border + const h = (colWidth / 2) / Math.cos(angle) + 3 // the rotation by default rotates from the middle of the line, // but we want the transform origin to be at its beginning // react native doesn't have transformOrigin, so we do this manually @@ -132,7 +133,7 @@ export default class DayColumn extends Component { return (<View width={h} position = 'absolute' - top={(leftY + rightY) / 2} + top={((leftY + rightY) / 2) - lineStyle.borderWidth / 2} left={projectedX} style={{ transform: [ -- GitLab