From 7d6e45b1e25070e2f03131d69086063e809f4f38 Mon Sep 17 00:00:00 2001
From: Julia Friesel <julia.friesel@gmail.com>
Date: Mon, 17 Sep 2018 18:33:12 +0200
Subject: [PATCH] Draw dot and line with svg

---
 components/chart/day-column.js   |  2 +-
 components/chart/dot-and-line.js | 50 ++++++++++----------------------
 components/chart/styles.js       | 26 +++++++----------
 3 files changed, 27 insertions(+), 51 deletions(-)

diff --git a/components/chart/day-column.js b/components/chart/day-column.js
index 4a638be8..a7e0d89d 100644
--- a/components/chart/day-column.js
+++ b/components/chart/day-column.js
@@ -191,7 +191,7 @@ export default class DayColumn extends Component {
           </View>
         </View>
 
-        <Svg width={config.columnWidth} height={chartHeight}>
+        <Svg width={config.columnWidth} height={columnHeight}>
           {column}
         </Svg>
 
diff --git a/components/chart/dot-and-line.js b/components/chart/dot-and-line.js
index 9d6daed3..4d49008f 100644
--- a/components/chart/dot-and-line.js
+++ b/components/chart/dot-and-line.js
@@ -1,5 +1,6 @@
 import React, { Component } from 'react'
-import { View } from 'react-native'
+import { Circle, Line } from 'react-native-svg'
+
 import styles from './styles'
 import config from '../../config'
 
@@ -17,21 +18,20 @@ export default class DotAndLine extends Component {
     if (this.props.leftY) {
       const middleY = ((this.props.leftY - y) / 2) + y
       const excludedLine = this.props.leftTemperatureExclude || exclude
-      lineToLeft = makeLine(middleY, y, 'left', excludedLine)
+      lineToLeft = makeLine(y, middleY, 0, excludedLine)
     }
     if (this.props.rightY) {
       const middleY = ((y - this.props.rightY) / 2) + this.props.rightY
       const excludedLine = this.props.rightTemperatureExclude || exclude
-      lineToRight = makeLine(y, middleY, 'right', excludedLine)
+      lineToRight = makeLine(y, middleY, config.columnWidth, excludedLine)
     }
 
     const dotStyle = exclude ? styles.curveDotsExcluded : styles.curveDots
     const dot = (
-      <View
-        position='absolute'
-        top={y - (dotStyle.height / 2)}
-        left={config.columnMiddle - (dotStyle.width / 2)}
-        style={dotStyle}
+      <Circle
+        cx={config.columnMiddle}
+        cy={y}
+        {...dotStyle}
         key='dot'
       />
     )
@@ -39,33 +39,15 @@ export default class DotAndLine extends Component {
   }
 }
 
-function makeLine(leftY, rightY, direction, excludeLine) {
-  const colWidth = config.columnWidth
-  const heightDiff = -(leftY - rightY)
-  const angle = Math.atan2(heightDiff, colWidth / 2)
+function makeLine(currY, middleY, x, excludeLine) {
   const lineStyle = excludeLine ? styles.curveExcluded : styles.curve
-  // hypotenuse, we add 3px for good measure, because otherwise the lines
-  // don't quite touch at the day border
-  const h = (colWidth / 2) / Math.cos(angle) + 10
-  // the rotation by default rotates from the middle of the line,
-  // but we want the transform origin to be at its beginning
-  // react native doesn't have transformOrigin, so we do this manually
-  // if it's the right line, we put the pivot at 3/4 of the column
-  // if it's to the left, at 1/4
-  const pivot = direction === 'right' ? colWidth / 4 : -(colWidth / 4)
-  const projectedX = -(h - colWidth) / 2 + pivot
 
-  return (<View
-    width={h}
-    position='absolute'
-    top={((leftY + rightY) / 2) - lineStyle.borderWidth / 2}
-    left={projectedX}
-    style={{
-      transform: [
-        { rotateZ: `${angle}rad` }
-      ],
-    }}
+  return <Line
+    x1={config.columnMiddle}
+    y1={currY}
+    x2={x}
+    y2={middleY}
     {...lineStyle}
-    key ={direction}
-  />)
+    key={x.toString()}
+  />
 }
\ No newline at end of file
diff --git a/components/chart/styles.js b/components/chart/styles.js
index 4e966841..e5d11999 100644
--- a/components/chart/styles.js
+++ b/components/chart/styles.js
@@ -3,32 +3,26 @@ import {primaryColor, shadesOfRed} from '../../styles/index'
 
 const colorTemperature = '#765285'
 const colorTemperatureLight = '#a67fb5'
-const dotWidth = 10
-const lineWidth = 2
+const dotRadius = 5
+const lineWidth = 1.5
 const colorLtl = '#feb47b'
 
 const styles = {
   curve: {
-    borderStyle: 'solid',
-    borderColor: colorTemperature,
-    borderWidth: lineWidth,
+    stroke: colorTemperature,
+    strokeWidth: lineWidth,
   },
   curveExcluded: {
-    borderColor: colorTemperatureLight,
-    borderWidth: lineWidth,
-    borderStyle: 'dotted'
+    stroke: colorTemperatureLight,
+    strokeWidth: lineWidth
   },
   curveDots: {
-    backgroundColor: colorTemperature,
-    width: dotWidth,
-    height: dotWidth,
-    borderRadius: 50
+    fill: colorTemperature,
+    r: dotRadius
   },
   curveDotsExcluded: {
-    backgroundColor: colorTemperatureLight,
-    width: dotWidth,
-    height: dotWidth,
-    borderRadius: 50
+    fill: colorTemperatureLight,
+    r: dotRadius
   },
   column: {
     label: {
-- 
GitLab